fix(streamable-http): close SSE responses on errors#2633
Open
Epochex wants to merge 3 commits into
Open
Conversation
Author
|
CI was failing only on Python 3.14 due to branch coverage reporting 256->exit in _handle_resumption_request cleanup. Added # pragma: no branch on the defensive if event_source is not None to keep branch coverage stable across 3.14 sysmon runs. All checks are green now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSE response objects can be leaked when streaming fails or ends unexpectedly.
This ensures HTTP responses are always closed in:
_handle_sse_response_handle_resumption_requestFixes #1450.
Tests: